Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add user profile #47

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

WIP: Add user profile #47

wants to merge 7 commits into from

Conversation

bf4
Copy link
Member

@bf4 bf4 commented Jun 24, 2013

As @bf4 and @rich-ware :

To surface user profile behind github authentication per avdi/ppwm#8

Thoughts of the feature 'finding your pair'

Finding Your Pair

User profile page

  • Show user profile info (wip)

Registered User features

  • 0) User has account on site, does not interfer with the 'matcher'
  • 1) has pairing interests
    1. [] technologies
    2. [] repos
    3. [] techniques
  • 2) site can contact user over email
  1. email address
  • 3) site can display contact info
  • 4) site needs scheduling ability

User profile information

  • email address
  • name / github user
  • how to contact
  • pairing interests
  • location
  • gravatar
  • time zone
  • twitter
  • about me

bf4 added 2 commits June 23, 2013 20:14
@bf4
BF/RB Get current user by github login, not a github object
b365925 
Benjamin Fleischer
Rich Blumer
@bf4
BF/RB Adding user profile route /profile/:github_login
28835b8 
If user is registered, show profile
else show 'no such user' page
@ghost ghost assigned bf4 Jun 24, 2013
@bf4 bf4 mentioned this pull request Jun 26, 2013
Closed
@joonty
Copy link

joonty commented Jun 28, 2013

I checked out this branch to give it a try, and got a parse error on the regex literal:

/home/jon/projects/ppwm-matcher/lib/ppwm_matcher/app.rb:103: empty range in char
class: /[\s-/\.]/ (SyntaxError)

It just needed the - to be escaped, as that's a special character in a character class.

Incidentally, what's the reason behind stripping characters out of the profile name?

@bf4
Copy link
Member Author

bf4 commented Jun 28, 2013

@joonty just thinking about cleaning params

@joonty
Copy link

joonty commented Jun 28, 2013

Ok, wouldn't ActiveRecord handle it though? In the where method, it does escaping on the input string.

Sorry if I'm missing the point, which is very possible!

@bf4
Copy link
Member Author

bf4 commented Jun 28, 2013

On Fri, Jun 28, 2013 at 8:54 AM, Jonathan Cairns
[email protected]:

Ok, wouldn't ActiveRecord handle it though? In the where method, it does
escaping on the input string.

Sorry if I'm missing the point, which is very possible!

No, I just didn't look into it. Will remove in the next iteration.

@bf4 bf4 mentioned this pull request Nov 11, 2013
Closed
@bf4 bf4 mentioned this pull request Feb 28, 2014
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bf4 bf4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bf4 @joonty